Move duplicateTemplatePart action to the @wordpress/fields package
#65390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
commented
Sep 17, 2024
packages/fields/src/components/create-template-part-modal/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to be reviewed! cc @oandregal @youknowriad @louwie17 |
youknowriad
reviewed
Nov 29, 2024
youknowriad
reviewed
Nov 29, 2024
youknowriad
reviewed
Nov 29, 2024
… into add/action-dataviews-3
youknowriad
reviewed
Dec 3, 2024
youknowriad
reviewed
Dec 3, 2024
Contributor
Author
Thanks for your review! 🙇 |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
WordPress#65390) Co-authored-by: gigitux <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
#65390) Co-authored-by: gigitux <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
ciampo
reviewed
Dec 6, 2024
| const defaultModalTitle = useSelect( | ||
| ( select ) => | ||
| select( coreStore ).getPostType( TEMPLATE_PART_POST_TYPE )?.labels | ||
| // @ts-ignore |
Contributor
There was a problem hiding this comment.
Is this // @ts-ignore necessary?
In general, I usually recommend using @ts-expect-error instead of @ts-ignore (this article explains the reason).
It's also usually a good idea to leave an inline comment explaining why we're ignoring/expecting a given TS error.
Contributor
Author
There was a problem hiding this comment.
Nice catch! I overlooked it when I iterate on this PR. Fixed with #67709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR migrates the
duplicateTemplatePartaction to the@wordpress/fieldspackage. The primary issue with this action is its dependency on theCreateTemplatePartModalContentscomponent, which resides in the@wordpress/editorpackage. Due to this, it can't be directly used within the@wordpress/fieldspackage.For the purpose of the
@wordpress/fieldspackage work, I have temporarily moved the component to this package. However, I'm not certain if this is the best long-term solution. Ideally, this component (and potentially others) should reside in a dedicated package, such as@wordpress/template, which would be more appropriate for components related to template and template-parts. A similar package for the patterns already exists: https://github.com/WordPress/gutenberg/blob/d6fcf4aea4aff17cf0910862bf10090e20ba2ab0/packages/patterns/srcPlease review and provide feedback on whether this approach is suitable or if there are alternative recommendations for handling these dependencies. Thanks! 🙏 cc @youknowriad @oandregal
Testing Instructions
Ensure that
Custom Dataviewsis enabled.Testing Instructions for Keyboard
Screenshots or screencast