Hide block transforms in contentOnly mode for non-content blocks #65394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
changed the title
|
Size Change: +57 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 18, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing well for me, and seems like a reasonable approach as it's only affecting this particular area where block variation transforms might be visibile.
Is this to prescriptive? We should check carefully whether there are situations where transforms are necessary even in contentOnly. I'm thinking about the Social Icons block or the Navigation block for example.
I don't think it's too proscriptive — the Social icons blocks don't set their variations to use the transform scope, so their icons aren't visible in this component anyway. In searching the repo for blocks that include variations that also use scope of transform, the main example I could find is with form blocks. And in that case, I think in content only mode, we'd also want to hide the transforms, as in this case the user wouldn't be switching out form elements? Here's the UI I mean:
So, I'd expect that to be hidden, too in content-only mode 👍
Is this performant?
Good question, but IMO this feels like a good place for the check to me.
Giving this a slightly tentative ✅, but overall seems like a good approach to me! 🚀
Contributor
Author
Thanks @andrewserong! I'll leave it open a little longer and if no more feedback I'll merge it. |
getdave
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
) * Hide transforms in contentOnly * Apply only to non-content blocks Co-authored-by: getdave <[email protected]> Co-authored-by: andrewserong <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 33ede7b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides any block transforms when block is in
contentOnlyblock editing mode and it is not a "content" block.Related #65396
Why?
The user should be focused on content not on transforming. Removes additional UI noise.
How?
Returns early from relevant component based on the mode. This is to avoid having to re-render the inspector controls entirely by adding a subscription to
getBlockEditingModewhich runs often.Concerns
contentOnly. I'm thinking about the Social Icons block or the Navigation block for example.Testing Instructions
contentOnly:Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-09-17.at.10-17-28.mp4