Skip to content

Script Modules: Centralize (re)registration #65460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 20 commits into from
Sep 20, 2024
Merged

Script Modules: Centralize (re)registration #65460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
487a982
PICKME: Add build-module to GH actions
sirreal Sep 19, 2024
11c63fe
Fix artifact download
sirreal Sep 20, 2024
44dd78f
Remove block-library view script module registration on render
sirreal Sep 18, 2024
508cbba
Produce combined script modules assetfile
sirreal Sep 18, 2024
00a196b
Fix script module webpack filenames
sirreal Sep 18, 2024
a148c74
Remove specific interactivity script module registration
sirreal Sep 18, 2024
5015d56
Handle re-registration of core script modules
sirreal Sep 18, 2024
b0b3e72
Fix script module re-registration
sirreal Sep 18, 2024
370f2e6
Move script module registration out of experimental
sirreal Sep 19, 2024
1bad15c
Just use assets.php
sirreal Sep 19, 2024
cb3a31b
Replace WP modules action with GB modules
sirreal Sep 19, 2024
476183a
Update function name, add deprecation note
sirreal Sep 19, 2024
3f457a5
Properly trim .min.js and .js
sirreal Sep 19, 2024
6759367
Remove unused filter function
sirreal Sep 20, 2024
ff352fc
Simplify module id creation and special casing
sirreal Sep 20, 2024
23bff87
Add core-backport file
sirreal Sep 20, 2024
b8e11bc
Use .min.js for webpack filename extension
sirreal Sep 20, 2024
8386d14
Merge branch 'fix/build-module-cached-unit-test-asset' into fix/block…
sirreal Sep 20, 2024
44da0b0
Use non-minified assets with SCRIPT_DEBUG
sirreal Sep 20, 2024
e99b96e
Remove usage of non-min .js files in Script Debug
sirreal Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Just use assets.php
  • Loading branch information
@sirreal
sirreal committed Sep 20, 2024
commit 1bad15c5c371d239fd7d8669aad58162b2412b08
2 changes: 1 addition & 1 deletion lib/client-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ function gutenberg_register_script_modules() {
* 'interactivity/debug.min.js' => array('dependencies' => array(…), 'version' => '…'),
* 'interactivity-router/index.min.js' => …
*/
$assets = include gutenberg_dir_path() . '/build-module/assets.production.php';
$assets = include gutenberg_dir_path() . '/build-module/assets.php';

foreach ( $assets as $file_name => $script_module_data ) {
$package_name = dirname( $file_name );
Expand Down
2 changes: 1 addition & 1 deletion tools/webpack/script-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ module.exports = {
...plugins,
new DependencyExtractionWebpackPlugin( {
combineAssets: true,
combinedOutputFile: `./assets.${ baseConfig.mode }.php`,
combinedOutputFile: `./assets.php`,
Copy link
Member

@gziolo gziolo Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge perf win! It will pay off over time. 👏

Copy link
Member

@gziolo gziolo Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to remember why there are two versions in WP core:

https://github.com/WordPress/wordpress-develop/blob/35907da95151b45d197102ea4d69e10ad019cab9/tools/webpack/packages.js#L201

All good here. I figured out that in WP core, there are two parallel build processes - one for development and one for production, so they shouldn't be overridden. It isn't the case here.

Copy link
Member

@gziolo gziolo Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the second thought:

npm run dev

Screenshot 2024-09-20 at 12 14 31

npm run build

Screenshot 2024-09-20 at 12 19 54

Notice the file name difference .js vs .min.js.

} ),
],
watchOptions: {
Expand Down