Search block: reset size correctly when clearing unit control #65468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4d5c35e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10929307417
|
mirka
approved these changes
Sep 19, 2024
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Nice bug fix! Works as expected 👍
Comment on lines
428
to
431
| widthUnit === '%' && | ||
| parseInt( newWidth, 10 ) > 100 | ||
| ? 100 | ||
| : newWidth; | ||
| const parsedNewWidth = parseInt( newWidth, 10 ); | ||
| setAttributes( { | ||
| width: parseInt( filteredWidth, 10 ), | ||
| width: Number.isNaN( parsedNewWidth ) | ||
| ? undefined | ||
| : parsedNewWidth, |
Member
There was a problem hiding this comment.
A bit nitty, but this makes it read like parsedNewWidth can be an invalid value (NaN), when in fact it was a valid value (empty string, aka undefined).
I think making that explicit in the parsing stage will avoid raising alarm bells for the reader. For example:
const parsedNewWidth =
newWidth === ''
? undefined
: parseInt( newWidth, 10 );
setAttributes( { width: parsedNewWidth } );
Contributor
Author
There was a problem hiding this comment.
Makes sense, I'll apply the suggestion and merge
ciampo
force-pushed
the
fix/search-block-width-NaN
branch
from
4d5c35e to
29d0d29
Compare
ciampo
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Search block: reset size correctly when clearing unit control * Make empty string handling more explicit --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 80df28e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #65340
Fix resetting the
widthof the Search block when clearing theUnitControlvalue in the block inspector sidebarWhy?
The behaviour on
trunkis buggy and doesn't reset correctly the widthHow?
There are two bug fixes:
onChangecallback for theUnitControlcomponent, the value is parsed from string to number, but is never checked forNaN(which happens when the input is cleared). The new code sets the width back toundefinedinstead ofNaNResizableBox'ssizeprop was incorrect:widthandheightproperties, but onlywidthwas specified. Now,heightis specified too;widthwas sometimes set toNaN, but that's implicitly fixed with the changes to theUnitControl'sonChangehandlerTesting Instructions
ButtonGroupin the block inspector sidebarUnitControlin the block inspector sidebarUnitControlin the block inspector sidebar:Screenshots or screencast
Kapture.2024-09-18.at.22.04.10.mp4
Kapture.2024-09-18.at.22.02.08.mp4