Skip to content

Command Palette: "Add new page" within the site editor creates new page in site editor #65476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 9 commits into from
Sep 20, 2024
Merged

Command Palette: "Add new page" within the site editor creates new page in site editor #65476

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0cdcd4f
First pass at forking the add page command depending on context.
ramonjd Sep 19, 2024
9e68e31
don't refresh the page when creating a page in the site editor
ramonjd Sep 19, 2024
89f138a
update e2e
ramonjd Sep 19, 2024
fa96990
close the command centre!
ramonjd Sep 19, 2024
1bd7626
Revert and move into site editor where we're unregistering the core c…
ramonjd Sep 19, 2024
76911d5
update e2e
ramonjd Sep 19, 2024
6cd5c52
Use existing command id (the one we're replacing)
ramonjd Sep 19, 2024
0bc7c1b
Move command into core commands
ramonjd Sep 19, 2024
4e5cb9e
Update package lock
andrewserong Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use existing command id (the one we're replacing)
  • Loading branch information
@ramonjd
ramonjd committed Sep 19, 2024
commit 6cd5c527beef95c716ca4d723399fdc558ba20e7
4 changes: 2 additions & 2 deletions packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function useAddNewPageCommand() {
const commands = useMemo( () => {
return [
{
name: 'core/edit-site/add-new-page',
name: 'core/add-new-page',
label: __( 'Add new page' ),
icon: plus,
callback: createPageEntity,
Expand All @@ -228,7 +228,7 @@ export function useEditModeCommands() {
unregisterCommand( 'core/add-new-page' );

useCommandLoader( {
name: 'core/edit-site/add-new-page',
name: 'core/add-new-page',
hook: useAddNewPageCommand,
} );

Expand Down