Revert "Make wordpress/fields a private package"
#65477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1a60dff.
noisysocks
added
Backport to WP 6.9 Beta/RC
noisysocks
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
Member
|
Oh, I see, that's unfortunate. No blockers from my side to making it public. |
Member
|
It wasn't in use when it got marked as private. Now, it definitely should. It was a miscommunication issue. |
gziolo
approved these changes
Sep 19, 2024
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
This reverts commit 1a60dff. Co-authored-by: noisysocks <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: oandregal <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 76af44f |
Member
|
I triggered npm publishing targeting WP 6.7 release. |
Member
Author
|
Thanks for confirming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #65269 which marked the
@wordpress/fieldspackage private. In other words, this PR makes it public.The problem with making
@wordpress/fieldsprivate is that it is used by Core/Gutenberg. Specifically, it's a dependency of@wordpress/editor:gutenberg/packages/editor/package.json
Line 50 in fe25bf1
This means that if you run
npm install @wordpress/editor(which we have to do to update packages in Core for 6.7) you get a 404 error when npm tries to download@wordpress/fields.I don't see a good way to "conditionally depend" on a package so I think the best thing to do is to just publish
@wordpress/fields. It's already a bundled package so there won't be awp.fieldsentry point. It would behave much like@wordpress/dataviews.Before I publish, I want to check with @oandregal, @youknowriad and @gziolo as it sounded like they might have had some reservations e.g. about the name #65230 (comment).