Skip to content

Block Bindings: Remove key fallback in bindings get values and rely on source label #65517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantosGuillamot merged 2 commits into from
Sep 20, 2024
Merged

Block Bindings: Remove key fallback in bindings get values and rely on source label #65517

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4bbea
Always fall back to source label
SantosGuillamot Sep 20, 2024
8894768
Adapt e2e tests
SantosGuillamot Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Always fall back to source label
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Sep 20, 2024
commit cb4bbea0c7ee2478863429200c3fa7ac6852e19a
5 changes: 2 additions & 3 deletions packages/block-editor/src/hooks/use-bindings-attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,8 @@ export const withBlockBindingSupport = createHigherOrderComponent(
let values = {};
if ( ! source.getValues ) {
Object.keys( bindings ).forEach( ( attr ) => {
// Default to the `key` or the source label when `getValues` doesn't exist
values[ attr ] =
bindings[ attr ].args?.key || source.label;
// Default to the the source label when `getValues` doesn't exist.
values[ attr ] = source.label;
} );
} else {
values = source.getValues( {
Expand Down