Skip to content

Global styles: do not navigate twice to home screen when opening the sidebar #65523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 2 commits into from
Sep 24, 2024
Merged

Global styles: do not navigate twice to home screen when opening the sidebar #65523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df2f06e
Global styles: do not navigate twice to home screen on sidebar load
ciampo Sep 20, 2024
0924465
Remove whole default block
ciampo Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/edit-site/src/components/global-styles/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,19 +272,6 @@ function GlobalStylesEditorCanvasContainerLink() {
goTo( '/' );
}
break;
default:
/*
* Example: the user has navigated to "Browse styles" or elsewhere
* and changes the editorCanvasContainerView, e.g., closes the style book.
* The panel should not be affected.
* Exclude revisions panel from this behavior,
* as it should close when the editorCanvasContainerView doesn't correspond.
*/
if ( path !== '/' && ! isRevisionsOpen ) {
return;
}
goTo( '/' );
break;
}
}, [ editorCanvasContainerView, isRevisionsOpen, goTo ] );
}
Expand Down