Skip to content

Button: Add __next40pxDefaultSize in dataviews, reusable-blocks, etc. #65715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 6 commits into from
Sep 30, 2024
Merged

Button: Add __next40pxDefaultSize in dataviews, reusable-blocks, etc. #65715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
266d609
Fix in Dataforms layouts
mirka Sep 28, 2024
cdc56a7
Fix in Patterns header
mirka Sep 28, 2024
1509a20
Fix in Patterns import popover
mirka Sep 28, 2024
69affc9
Fix in nux
mirka Sep 28, 2024
848ff10
Fix in ReusableBlockConvertButton
mirka Sep 28, 2024
8b642e0
Update snapshot
mirka Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix in Patterns header
  • Loading branch information
@mirka
mirka committed Sep 28, 2024
commit cdc56a711e601dd943df7d746bb77ae27b30e77b
4 changes: 2 additions & 2 deletions packages/list-reusable-blocks/src/components/import-dropdown/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ function ImportDropdown( { onUpload } ) {
contentClassName="list-reusable-blocks-import-dropdown__content"
renderToggle={ ( { isOpen, onToggle } ) => (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
size="compact"
className="list-reusable-blocks-import-dropdown__button"
Comment on lines +20 to +21
Copy link
Member Author

@mirka mirka Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to http://localhost:8888/wp-admin/edit.php?post_type=wp_block.

Before After
Import from JSON button, before Import from JSON button, after

aria-expanded={ isOpen }
onClick={ onToggle }
variant="primary"
Expand Down
5 changes: 5 additions & 0 deletions packages/list-reusable-blocks/src/components/import-dropdown/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
.list-reusable-blocks-import-dropdown__content .components-popover__content {
padding: 10px;
}

[class].list-reusable-blocks-import-dropdown__button {
Copy link
Member Author

@mirka mirka Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[class] selector added for more specificity.

Copy link
Member

@tyxla tyxla Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer this is necessary, but it makes sense since the other button is outside our control.

// Todo: Make core button height and gutenberg button height equal.
height: 30px;
}
4 changes: 0 additions & 4 deletions packages/list-reusable-blocks/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
align-items: center;
position: relative;
top: -3px;
// Todo: Make core button height and gutenberg button height equal.
.components-button {
height: 26px;
}
Comment on lines -9 to -12
Copy link
Member Author

@mirka mirka Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a custom class name in packages/list-reusable-blocks/src/components/import-dropdown/style.scss.

}

@include wordpress-admin-schemes();