Skip to content

Composite: make items tabbable if active element gets removed #65720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 4 commits into from
Oct 3, 2024
Merged

Composite: make items tabbable if active element gets removed #65720

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a928068
Composite: make items tabbable when the active element is disconnected
ciampo Sep 28, 2024
5391cd3
Add unit test
ciampo Sep 30, 2024
70997a6
Better test name
ciampo Oct 2, 2024
7de8ae6
CHANGELOG
ciampo Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better test name
  • Loading branch information
@ciampo
ciampo committed Oct 3, 2024
commit 70997a6edf4a787741c9ad61a72684d296ad7fca
2 changes: 1 addition & 1 deletion packages/components/src/composite/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function RemoveItemTest( props: ComponentProps< typeof Composite > ) {
}

describe( 'Composite', () => {
it( 'should remain focussable even when there is no elements in the DOM associated with the currently active ID', async () => {
it( 'should remain focusable even when there are no elements in the DOM associated with the currently active ID', async () => {
await renderAndValidate( <RemoveItemTest /> );

const toggleButton = screen.getByRole( 'button', {
Expand Down