Skip to content

Button: Add __next40pxDefaultSize in block-editor 6 #65742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 5 commits into from
Oct 1, 2024
Merged

Button: Add __next40pxDefaultSize in block-editor 6 #65742

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42c3737
Fix in Skip to selected block
mirka Sep 30, 2024
a4ad907
Fix in Tool selector
mirka Sep 30, 2024
366204d
Fix in URLInputButton
mirka Sep 30, 2024
49f0f12
Fix in URLInput
mirka Sep 30, 2024
398e2d6
Remove dead code in FlexLayoutVerticalAlignmentControl
mirka Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix in URLInput
  • Loading branch information
@mirka
mirka committed Sep 30, 2024
commit 49f0f128afc45f6e98991a9d03544e74cf6b5015
3 changes: 1 addition & 2 deletions packages/block-editor/src/components/url-input/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,7 @@ class URLInput extends Component {
>
{ suggestions.map( ( suggestion, index ) => (
<Button
// TODO: Switch to `true` (40px size) if possible
__next40pxDefaultSize={ false }
__next40pxDefaultSize
Copy link
Member Author

@mirka mirka Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert a Paragraph block, select a string range and click the Link button in the block toolbar. I'm not sure what conditions are needed to reach this code naturally — it's not what you normally see in a URLInput in Gutenberg. To force the condition, you can comment out the block with the if ( isFunction( renderSuggestions ) ) conditional, a few lines above this.

Before After
URLInput, before URLInput, after

{ ...buildSuggestionItemProps( suggestion, index ) }
key={ suggestion.id }
className={ clsx(
Expand Down