Skip to content

Try zooming out when selecting the patterns tab in the inserter #65785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
draganescu merged 3 commits into from
Oct 7, 2024
Merged

Try zooming out when selecting the patterns tab in the inserter #65785

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea8bcf8
adds handler for inserter tabs that engages zoom out view and mode
draganescu Oct 1, 2024
959e07a
Only moving to blocks should reset zoom out mode
getdave Oct 1, 2024
14ba0f7
use hook to handle zoom out view, the hook respects the current zoom …
draganescu Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use hook to handle zoom out view, the hook respects the current zoom … 
…out setting
  • Loading branch information
@draganescu
draganescu committed Oct 7, 2024
commit 14ba0f7687f52222861dc66e1c0efcd34916aab4
23 changes: 6 additions & 17 deletions packages/block-editor/src/components/inserter/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
import { VisuallyHidden, SearchControl, Popover } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { useDebouncedInput } from '@wordpress/compose';
import { useSelect, useDispatch } from '@wordpress/data';
import { useSelect } from '@wordpress/data';

/**
* Internal dependencies
Expand All @@ -32,7 +32,7 @@ import InserterSearchResults from './search-results';
import useInsertionPoint from './hooks/use-insertion-point';
import { store as blockEditorStore } from '../../store';
import TabbedSidebar from '../tabbed-sidebar';
import { unlock } from '../../lock-unlock';
import { useZoomOut } from '../../hooks/use-zoom-out';

const NOOP = () => {};
function InserterMenu(
Expand Down Expand Up @@ -78,6 +78,10 @@ function InserterMenu(
}
const [ selectedTab, setSelectedTab ] = useState( getInitialTab() );

const shouldUseZoomOut =
selectedTab === 'patterns' || selectedTab === 'media';
useZoomOut( shouldUseZoomOut );

const [ destinationRootClientId, onInsertBlocks, onToggleInsertionPoint ] =
useInsertionPoint( {
rootClientId,
Expand Down Expand Up @@ -284,22 +288,7 @@ function InserterMenu(
showMediaPanel,
] );

const { resetZoomLevel, setZoomLevel, __unstableSetEditorMode } = unlock(
useDispatch( blockEditorStore )
);

const handleZoomOut = ( newSelectedTab ) => {
if ( isZoomOutMode && newSelectedTab === 'blocks' ) {
resetZoomLevel();
__unstableSetEditorMode( 'edit' );
} else if ( ! isZoomOutMode && newSelectedTab === 'patterns' ) {
setZoomLevel( 50 );
__unstableSetEditorMode( 'zoom-out' );
}
};

const handleSetSelectedTab = ( value ) => {
handleZoomOut( value );
// If no longer on patterns tab remove the category setting.
if ( value !== 'patterns' ) {
setSelectedPatternCategory( null );
Expand Down