Skip to content

Interactivity API: Allow more directives suffixes #65803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 12 commits into from
Closed

Interactivity API: Allow more directives suffixes #65803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
191422f
Relax client-side iAPI directives matching
sirreal Oct 1, 2024
46f893f
Use non-capturing group in regexp
sirreal Oct 2, 2024
936cf52
Fix string splitting
sirreal Oct 2, 2024
23943bd
Adjust context tests
sirreal Oct 2, 2024
9911253
Add test for unusual class directive characters
sirreal Oct 2, 2024
20bf028
Added some extra comments
michalczaplinski Oct 7, 2024
d4739b4
Add more detailed comments on prefixes and suffixes in vdom.ts
michalczaplinski Oct 7, 2024
8d36bc0
Merge branch 'trunk' into fix/core-62131-arbitrary-directive-suffixes
sirreal Oct 7, 2024
c5b8aed
Reuse single classProxyElement outside loop
sirreal Oct 7, 2024
b04c568
Handle HTML entities and spaces in classes
sirreal Oct 8, 2024
4323fa5
Test captial letters
sirreal Oct 8, 2024
026c323
Test " character in class name suffix
sirreal Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for unusual class directive characters
  • Loading branch information
@sirreal
sirreal committed Oct 2, 2024
commit 99112535592e731589f5da1387a96c55c60de38b
4 changes: 4 additions & 0 deletions packages/e2e-tests/plugins/interactive-blocks/directive-class/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,8 @@ class="foo"
data-testid="can use classes with several dashes"
></div>

<div
data-wp-class--#[^+-]$="context.value"
data-testid="class name no-aplhanumeric"
></div>
</div>
13 changes: 13 additions & 0 deletions test/e2e/specs/interactivity/directive-class.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,17 @@ test.describe( 'data-wp-class', () => {
const el = page.getByTestId( 'can use classes with several dashes' );
await expect( el ).toHaveClass( 'main-bg----color' );
} );

test( 'can use class names with non-alphanumeric characters', async ( {
page,
} ) => {
const expectedClassName = '#[^+-]$';
const el = page.getByTestId( 'class name no-aplhanumeric' );
const toggle = page.getByTestId( 'toggle context value' );
await expect( el ).not.toHaveClass( expectedClassName );
await toggle.click();
await expect( el ).toHaveClass( expectedClassName );
await toggle.click();
await expect( el ).not.toHaveClass( expectedClassName );
} );
} );