Skip to content

Global styles: font size panel crashing when navigating back #65811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 2 commits into from
Closed

Global styles: font size panel crashing when navigating back #65811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38a546
When navigating back from the font sizes panel, the origin and slug n…
ramonjd Oct 2, 2024
c3b9a7f
Reinstate goTo
ramonjd Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
When navigating back from the font sizes panel, the origin and slug n… 
…avigation params are not available so let's return early.

Also, remove goTo call in the ScreenHeader onBack callback since back navigation is built into `Navigator.BackButton`
  • Loading branch information
@ramonjd
ramonjd committed Oct 2, 2024
commit f38a546175a0a15b262803dd518e23a5e124f8a5
6 changes: 4 additions & 2 deletions packages/edit-site/src/components/global-styles/font-sizes/font-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function FontSize() {
const {
params: { origin, slug },
goBack,
goTo,
} = useNavigator();

const [ fontSizes, setFontSizes ] = useGlobalSetting(
Expand All @@ -46,6 +45,10 @@ function FontSize() {

const [ globalFluid ] = useGlobalSetting( 'typography.fluid' );

if ( ! origin || ! slug ) {
return;
}

// Get the font sizes from the origin, default to empty array.
const sizes = fontSizes[ origin ] ?? [];

Expand Down Expand Up @@ -151,7 +154,6 @@ function FontSize() {
__( 'Manage the font size %s.' ),
fontSize.name
) }
onBack={ () => goTo( '/typography/font-sizes/' ) }
/>
{ origin === 'custom' && (
<FlexItem>
Expand Down