Skip to content

Global styles: improve navigation logic for revisions screen #65946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 5 commits into from
Oct 10, 2024
Merged

Global styles: improve navigation logic for revisions screen #65946

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28bad8c
Global styles: improve navigation logic for revisions screen
ciampo Oct 8, 2024
50d6cab
Merge style book case into default, add comment
ciampo Oct 8, 2024
b3dcbe2
Remove unnecessary goTo calls
ciampo Oct 8, 2024
8602981
Remove useNavigator import
ramonjd Oct 9, 2024
d53f641
Apply feedback
ciampo Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply feedback
  • Loading branch information
@ciampo
ciampo committed Oct 10, 2024
commit d53f641b9e493ba770acb7c0870539c4fe694881
8 changes: 8 additions & 0 deletions packages/edit-site/src/components/global-styles/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,14 @@ function GlobalStylesEditorCanvasContainerLink() {
case 'global-styles-css':
goTo( '/css' );
break;
// The stand-alone style book is open
// and the revisions panel is open,
// close the revisions panel.
// Otherwise keep the style book open while
// browsing global styles panel.
//
// Falling through as it matches the default scenario.
case 'style-book':
default:
// In general, if the revision screen is in view but the
// `editorCanvasContainerView` is not a revision view, close it.
Expand Down