Fix caretRangeFromPoint for Firefox #6598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Writing Flow
aduth
approved these changes
May 4, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Confirmed resolves error 👍
Is there some documentation / specification that describes this behavior we could include as a reference link? Or mention that it's Firefox-specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is an error in Firefox when moving the caret down with the arrow key, and the target block is outside of the viewport. In that case
caretPositionFromPointreturnsnullandrange.setStartfails. There will be no scrolling with a second attempt. To fix this we have to returnnullto prevent the error, and a second attempt will be made by scrolling the page.How has this been tested?
See above.
Screenshots
Types of changes
Checklist: