Skip to content

Fix site editor back button visual regressions #66166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 3 commits into from
Oct 16, 2024
Merged

Fix site editor back button visual regressions #66166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd11149
Fix site editor back button visual quirks
jameskoster Oct 16, 2024
487f0b0
Update packages/edit-site/src/components/sidebar-button/style.scss
jameskoster Oct 16, 2024
612797c
Update :active selector
jameskoster Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix site editor back button visual quirks
  • Loading branch information
@jameskoster
jameskoster committed Oct 16, 2024
commit fd11149b51d023f379bb88891e0d0fa848f1ec23
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Button } from '@wordpress/components';
export default function SidebarButton( props ) {
return (
<Button
__next40pxDefaultSize
size="compact"
{ ...props }
className={ clsx( 'edit-site-sidebar-button', props.className ) }
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
outline: 3px solid transparent;
}

&:hover,
&:hover:not(:disabled,[aria-disabled=true]),
&:focus-visible,
&:focus,
&:not([aria-disabled="true"]):active,
Copy link
Contributor

@ciampo ciampo Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add :disabled here too, to align with the selector introduced above?

Copy link
Contributor

@ciampo ciampo Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, looking forward to color theming which will hopefully make such overrides unneded

Expand Down
6 changes: 5 additions & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@
.edit-site-sidebar-navigation-screen__title {
flex-grow: 1;
overflow-wrap: break-word;
padding: $grid-unit-05 * 0.5 0 0 0;

&#{&},
&#{&} .edit-site-sidebar-navigation-screen__title {
line-height: $font-line-height-x-large;
}
}

.edit-site-sidebar-navigation-screen__actions {
Expand Down