Skip to content

Add InspectorBlockInfo using SlotFill method #66170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthick-murugan wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Add InspectorBlockInfo using SlotFill method #66170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fe166a
Inspector Block Info added
karthick-murugan Oct 15, 2024
cd4e6c7
Add Dependencies Comment
karthick-murugan Oct 15, 2024
3c9b9d0
Changing class names more relevant
karthick-murugan Oct 16, 2024
3b41cf8
Updating the SlotFill Inside BlockInformation
karthick-murugan Oct 16, 2024
a496b78
Removing test file changes
karthick-murugan Oct 16, 2024
edb99aa
Fixing Linting issues
karthick-murugan Oct 16, 2024
6af8b89
Fixing JS linting issues
karthick-murugan Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updating the SlotFill Inside BlockInformation
  • Loading branch information
@karthick-murugan
karthick-murugan committed Oct 16, 2024
commit 3b41cf897b6a5345a136a18f4a8adee5b710ef59
9 changes: 4 additions & 5 deletions packages/block-editor/src/components/block-card/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ import { useSelect, useDispatch } from '@wordpress/data';
*/
import BlockIcon from '../block-icon';
import { store as blockEditorStore } from '../../store';
import InspectorBlockInfoFill from '../inspector-block-info/inspector-block-info';

function BlockCard( { title, icon, description, blockType, className, name } ) {
function BlockCard( { title, icon, description, blockType, className, name, inspectorBlockInfo } ) {
if ( blockType ) {
deprecated( '`blockType` property in `BlockCard component`', {
since: '5.7',
Expand Down Expand Up @@ -79,11 +78,11 @@ function BlockCard( { title, icon, description, blockType, className, name } ) {
{ description && (
<Text className="block-editor-block-card__description">
{ description }
<div className="block-editor-block-card__inspector-block-info">
{ inspectorBlockInfo }
</div>
</Text>
) }
<div className="block-editor-block-card__inspector-block-info">
<InspectorBlockInfoFill.Slot />
</div>
</VStack>
</div>
);
Expand Down
3 changes: 3 additions & 0 deletions packages/block-editor/src/components/use-block-display-information/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
__experimentalGetBlockLabel as getBlockLabel,
} from '@wordpress/blocks';
import { __ } from '@wordpress/i18n';
import InspectorBlockInfoFill from '../inspector-block-info/inspector-block-info';

/**
* Internal dependencies
Expand Down Expand Up @@ -98,6 +99,7 @@ export default function useBlockDisplayInformation( clientId ) {
positionLabel,
positionType: attributes?.style?.position?.type,
name: attributes?.metadata?.name,
inspectorBlockInfo: <InspectorBlockInfoFill.Slot />
};
if ( ! match ) {
return blockTypeInfo;
Expand All @@ -112,6 +114,7 @@ export default function useBlockDisplayInformation( clientId ) {
positionLabel,
positionType: attributes?.style?.position?.type,
name: attributes?.metadata?.name,
inspectorBlockInfo: <InspectorBlockInfoFill.Slot />
};
},
[ clientId ]
Expand Down
11 changes: 11 additions & 0 deletions packages/block-library/src/button/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
__experimentalGetElementClassName,
store as blockEditorStore,
useBlockEditingMode,
InspectorBlockInfoFill,
} from '@wordpress/block-editor';
import { displayShortcut, isKeyboardEvent, ENTER } from '@wordpress/keycodes';
import { link, linkOff } from '@wordpress/icons';
Expand Down Expand Up @@ -146,6 +147,15 @@ function WidthPanel( { selectedWidth, setAttributes } ) {
);
}

const InspectorBlockInfo = () => {
return (
<InspectorBlockInfoFill>
<a href='https://wordpress.org/documentation/article/buttons-block/'>Button</a>
<p>this is a test para</p>
</InspectorBlockInfoFill>
);
};

function ButtonEdit( props ) {
const {
attributes,
Expand Down Expand Up @@ -389,6 +399,7 @@ function ButtonEdit( props ) {
/>
) }
</InspectorControls>
<InspectorBlockInfo />
</>
);
}
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/popover/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,6 @@ const getPopoverFallbackContainer = () => {
document.body.append( container );
}

// Select the element with class 'block-editor-block-card__inspector-block-info' inside the container
const descriptionExtender = container.querySelector(
'.block-editor-block-card__inspector-block-info'
);

// If found, remove the element
if ( descriptionExtender ) {
descriptionExtender.remove();
}

return container;
};

Expand Down