Fix text editor style regression #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a PR to fix a regression I introduced in #603 (review). This moves the styles to input fields to be scoped to blocks, and the sidebar, both of which will benefit from this style.
jasmussen
added
[Feature] Blocks
aduth
approved these changes
May 4, 2017
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Unclear whether this belongs in the "root" stylesheet vs. individually per sidebar and visual editor components (maybe with mixin), but this seems fine enough 👍
Contributor
Author
Yep, was unsure as well, but decided to go with the root stylesheet to avoid duplication of the styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix a regression I introduced in #603 (review).
This moves the styles to input fields to be scoped to blocks, and the sidebar, both of which will benefit from this style.