Remove relative position from sidebar tabpanel #66267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
approved these changes
Oct 21, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thank you for the quick fix!
✅ The pattern category flyout is displayed correctly again
✅ The scrollbar issue when searching for blocks is not present
✅ Working correctly in both the post and site editors
LGTM! 🚀
ramonjd
approved these changes
Oct 21, 2024
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Tested in FF, Edge, Chrome and Safari.
thanks for the quick fix!
| 😢 | 😄 |
|---|---|
 |
 |
aaronrobertshaw
approved these changes
Oct 21, 2024
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM 🚀
✅ No double scrollbars
✅ Patterns are back
✅ Media tab works as expected
Screen.Recording.2024-10-21.at.10.22.15.am.mp4
|
Size Change: -6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: d2efcdc |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes pattern preview display in the sidebar:
tabpanelscroll.mp4
Removes a
position: relativeintroduced in #66229 that isn't strictly needed to fix the bug that PR addresses.The original issue was caused by a
VisuallyHiddencomponent attached to the search bar in the panel header. That is fixed by theposition: relativeadded to the header component. Addingposition: relativeto the tabpanel itself interferes with the pattern preview slideout sections, which are positioned relatively to the canvas.As @talldan mentioned in the previous PR, it might be worth looking into fixing this in
VisuallyHiddenitself, but this close to RC1 it's best to aim for the smallest possible fix 😅Thanks to @ramonjd for locating the line responsible for the breakage!
Testing Instructions