Fix: JSON Schema Docgen doesn't work on Windows OS #66414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63868
Reported in this comment on Slack
Original report
What?
This PR fixes the
docs:theme-refcommand so that it works on Windows OS.Why?
When running the
docs:theme-refcommand on Windows OS, the following error occurs:When we investigated this issue, we found that
THEME_JSON_SCHEMA_URL.pathnamehas an invalid path like the following:I found a similar report about this path in the node project: nodejs/node#37845
How?
According to the comment, this path is a valid URL, but it seems that the URL needs to be converted to a path:
Testing Instructions
schemas/json/theme.jsonfile.npm run docs:theme-ref.theme-json-living.mdfile should be updated.