Skip to content

Preload: fix multiple regressions around global styles #66468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 10 commits into from
Oct 28, 2024
Merged

Preload: fix multiple regressions around global styles #66468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec6ad3f
Preload: fix global styles regression
ellatrix Oct 25, 2024
ece965d
fix whitespace
ellatrix Oct 25, 2024
e6f8b5f
Fix notic
ellatrix Oct 25, 2024
12efb60
PHP lint
ellatrix Oct 25, 2024
167c596
Fix the other request too
ellatrix Oct 25, 2024
2ae7a9c
Fix whitespace again
ellatrix Oct 25, 2024
f4d9985
Fix unnecessary requests
ellatrix Oct 25, 2024
2da07af
Also preload variations
ellatrix Oct 25, 2024
659305b
Avoid early return and let isReady be set
ellatrix Oct 28, 2024
a9d2ec1
Add backport
ellatrix Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add backport
  • Loading branch information
@ellatrix
ellatrix committed Oct 28, 2024
commit a9d2ec14a11af4fc641442428b418f821a936f6b
3 changes: 3 additions & 0 deletions backport-changelog/6.8/7661.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
https://github.com/WordPress/wordpress-develop/pull/7661

* https://github.com/WordPress/gutenberg/pull/66468
8 changes: 2 additions & 6 deletions packages/editor/src/components/global-styles-provider/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,12 @@ function useGlobalStylesUserConfig() {
const _globalStylesId =
select( coreStore ).__experimentalGetCurrentGlobalStylesId();

let record;

// We want the global styles ID request to finish before triggering
// the OPTIONS request for user capabilities, otherwise it will
// fetch `/wp/v2/global-styles` instead of
// `/wp/v2/global-styles/{id}`!
if ( ! _globalStylesId ) {
return { isReady: false };
}

let record;

// Please adjust the preloaded requests if this changes!
const userCanEditGlobalStyles = _globalStylesId
? canUser( 'update', {
Expand Down