Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

ramonjd · 2024-10-29T01:41:56Z

What?

Follow up to:

Preload: fix multiple regressions around global styles #66468

#66468 will be cherry picked to 6.7 since it's a regression.

Why?

Given that this fixes a 6.7 regression move the code into 6.7 compat.

How?

Copy paste

Testing Instructions

Fire up this branch and head to the site editor.

Check that global-styles endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_request

Do the same for the post editor.

Screenshots or screencast

github-actions · 2024-10-29T01:42:08Z

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: [Type] Regression, Global Styles, Backport from WordPress Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions · 2024-10-29T01:42:10Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

aaronrobertshaw · 2024-10-29T02:07:17Z

backport-changelog/6.8/7661.md

 https://github.com/WordPress/wordpress-develop/pull/7661

 * https://github.com/WordPress/gutenberg/pull/66468
+* https://github.com/WordPress/gutenberg/pull/66543


I think this might need moving to the 6.7 backport-changelog folder too.

andrewserong

Thanks for the follow-up, this is testing well for me!

Looks like the only change is $stylesheet being renamed to $active_theme 👍

Once the backport .md file is moved to 6.7, this looks good to land to me!

aaronrobertshaw

LGTM!

Global styles paths are still preloaded correctly.

🚢

ramonjd · 2024-10-29T02:15:55Z

Thanks for the quick reviews, folks!

…tyles (#66468) (#66542) * Sync with #66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]>

…n post editor. Sync with #66543

…n post editor. Sync with #66543 Update comment

…tyles (#66468) (#66542) * Sync with WordPress/gutenberg#66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]> Source: WordPress/gutenberg@cf008a0

…n post editor. Sync with #66543 Update comment

…dPress#66543) * Given that this fixes a 6.7 regression move the code into 6.7 compat. * Move for loop into context block * Move backport log to 6.7 Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]>

…tyles (#66468) (#66542) * Sync with WordPress/gutenberg#66543 * Move backport log to 6.7 --------- Co-authored-by: ellatrix <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]> Source: WordPress/gutenberg@cf008a0

Given that this fixes a 6.7 regression move the code into 6.7 compat.

88e6edd

ramonjd self-assigned this Oct 29, 2024

ramonjd requested a review from spacedmonkey as a code owner October 29, 2024 01:41

Update backport md

01640f3

ramonjd mentioned this pull request Oct 29, 2024

Cherry Pick to 6.7: Preload: fix multiple regressions around global styles (#66468) #66542

Merged

ramonjd requested review from aaronrobertshaw, andrewserong and ellatrix October 29, 2024 01:44

Move for loop into context block

787de85

ramonjd added a commit that referenced this pull request Oct 29, 2024

Sync with #66543

287828a

aaronrobertshaw reviewed Oct 29, 2024

View reviewed changes

andrewserong approved these changes Oct 29, 2024

View reviewed changes

Move backport log to 6.7

4712924

aaronrobertshaw approved these changes Oct 29, 2024

View reviewed changes

ramonjd enabled auto-merge (squash) October 29, 2024 02:16

ramonjd merged commit dc4bd05 into trunk Oct 29, 2024

ramonjd deleted the update/move-global-styles-preload-from-6.8-to-6.7 branch October 29, 2024 02:45

github-actions bot mentioned this pull request Oct 29, 2024

PHP backports for WP 6.7 #63827

Closed

github-actions bot added this to the Gutenberg 19.6 milestone Oct 29, 2024

ramonjd added a commit that referenced this pull request Oct 30, 2024

Sync with #66543

a53ebf8

ramonjd added a commit that referenced this pull request Oct 30, 2024

Sync with #66543

ead5d8b

ramonjd added a commit that referenced this pull request Oct 30, 2024

Change context depending on user caps to prevent clientside request i…

52173f5

…n post editor. Sync with #66543

ramonjd added a commit that referenced this pull request Oct 30, 2024

Change context depending on user caps to prevent clientside request i…

58aa39f

…n post editor. Sync with #66543 Update comment

cbravobernal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Oct 30, 2024

ramonjd added a commit that referenced this pull request Oct 31, 2024

Change context depending on user caps to prevent clientside request i…

c5a3db3

…n post editor. Sync with #66543 Update comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

Uh oh!

ramonjd commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

aaronrobertshaw Oct 29, 2024

Uh oh!

andrewserong left a comment

Uh oh!

aaronrobertshaw left a comment

Uh oh!

ramonjd commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

Global styles: move preload paths filter to 6.7 (previously 6.8) #66543

Uh oh!

Conversation

ramonjd commented Oct 29, 2024

What?

Why?

How?

Testing Instructions

Screenshots or screencast

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronrobertshaw Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

andrewserong left a comment

Choose a reason for hiding this comment

Uh oh!

aaronrobertshaw left a comment

Choose a reason for hiding this comment

Uh oh!

ramonjd commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading