Skip to content

Conversation

@ellatrix
Copy link
Member

What?

See #66579 (comment).

There must be some kind of race condition that that PR surfaced in Safari, so this serves as a temporary fix while I investigate the issue.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Oct 31, 2024
@github-actions
Copy link

github-actions bot commented Oct 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <[email protected]>
Co-authored-by: mcsf <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ellatrix ellatrix requested a review from mcsf October 31, 2024 17:10
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Speedy!

@ellatrix ellatrix added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Oct 31, 2024
@github-actions
Copy link

Flaky tests detected in 338b51b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11616617361
📝 Reported issues:

@ellatrix ellatrix merged commit 489f606 into trunk Oct 31, 2024
@ellatrix ellatrix deleted the try/remove-setting-preload branch October 31, 2024 17:53
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Oct 31, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants