Query Loop: Check for postTypeFromContext before using it #66655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
approved these changes
Oct 31, 2024
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Perhaps at some point we should add some e2e tests.
Member
Author
|
Yes, e2e tests would be good! Happy to work on that as a follow-up. |
|
Size Change: +4 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…66655) Co-authored-by: mikachan <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue introduced in #65820, where the Query Loop block gets stuck showing the loading spinner after being inserted.
Why?
It seems to be because we're trying to use
postTypeFromContextwhen it's undefined, so we should check that it exists before running logic against it.How?
Check for
postTypeFromContextbefore using it.Testing Instructions
Screenshots or screencast