Data: upgrade Redux to v5.0.1 #66966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 task
|
Size Change: -282 B (-0.02%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Nov 13, 2024
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
I just skimmed the Redux release notes and couldn't spot anything breaking that might affect the block editor code base.
It looks like createStore has been marked as deprecated since 4.2. Should we switch to legacy_createStore to make current intentions clear? I'm not sure it's doable for this project to migrate to RTK.
Member
Author
Maybe, but I don't think it's particularly important. A striked-out
Agreed, in a sense |
|
Flaky tests detected in ac2fea2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11818428875
|
Member
|
I always forget about changelogs, but it could be helpful in this case - #66968. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's upgrade Redux to the latest version 5.0.1. There are apps that use both
@wordpress/dataand plainreduxand the fact that we still use the old 4.x version causes unnecessarynode_modulesconflicts.There shouldn't be any visible changes, after all, the
reduxAPI surface is very small. Maybe only the TS types might have some incompatible changes, but I don't see any.