Skip to content

SlotFill: fix a bug with storing stale fillProps #67000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 4 commits into from
Nov 15, 2024
Merged

SlotFill: fix a bug with storing stale fillProps #67000

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d09b2
SlotFill: updateSlot should check the ref
jsnajdr Nov 7, 2024
7bd8715
Slot: store fillProps to a ref to fix effect deps
jsnajdr Nov 7, 2024
4c78204
SlotFillProvider: tidy up API code
jsnajdr Nov 7, 2024
7fa987d
Add changelog entry
jsnajdr Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add changelog entry
  • Loading branch information
@jsnajdr
jsnajdr committed Nov 15, 2024
commit 7fa987dd3d39a5b19e772c6fc78a56b98852c3e2
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- `Popover`: Fix missing label of the headerTitle Close button ([#66813](https://github.com/WordPress/gutenberg/pull/66813)).
- `ToggleGroupControl`: Fix active background for `0` value ([#66855](https://github.com/WordPress/gutenberg/pull/66855)).
- `SlotFill`: Fix a bug where a stale value of `fillProps` could be used ([#67000](https://github.com/WordPress/gutenberg/pull/67000)).

### Enhancements

Expand Down
Loading