Skip to content

Image alignment issue fix #67388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rinkalpagdar wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Image alignment issue fix #67388

rinkalpagdar wants to merge 1 commit into from

Conversation

@rinkalpagdar
Copy link
Contributor

@rinkalpagdar rinkalpagdar commented Nov 28, 2024

Fix #65305

What?

Fixes image alignment issue.

How?

By removing the float property it will fix the styling issue.

@github-actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: stokesman <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Nov 30, 2024
@stokesman
Copy link
Contributor

stokesman commented Mar 10, 2025

I haven’t tested this. I can’t imagine that this could be a workable solution because left/right alignments have always been floats. This would seem likely to change the appearance of existing sites and that’s not acceptable. Let me know if you think I’m missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image block resizer: layout issues in the editor when an image block follows a left or right aligned image block

3 participants

@rinkalpagdar @stokesman @t-hamano