Add types for shortcode package

[manzoorwanijk]

What?

Add TS types for shortcode package.

Why?

To have better type safety and to unblock blocks package being converted to TS

How?

Unlike #60526, this PR extracts the JSDoc types to a types.ts file to expose types without making changes to the actual JS code.

However, the next steps should be to convert shortcode Object.assign to JS Class declaration for better code quality.

Testing Instructions

• Verify that CI is happy

Testing Instructions for Keyboard

Screenshots or screencast

Next steps

Deprecate @types/wordpress__shortcode after this PR gets merged and released to npm.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <[email protected]>
Co-authored-by: gziolo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[gziolo]

However, the next steps should be to convert shortcode Object.assign to JS Class declaration for better code quality.

Sounds fine, but only makes sense if the file gets converted fully to TypeScript.

[manzoorwanijk]

Sounds fine, but only makes sense if the file gets converted fully to TypeScript.

Yes, that's the plan.

[gziolo]

Nice one. Thank you for working on it.

I had only one question. We also should update the changelog to include the note that types are now available. 🎉

[manzoorwanijk]

Adding changelog now

[gziolo]

Awesome, thank you!