Skip to content

DataViews: Move template and pattern title fields #67449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 11 commits into from
Dec 5, 2024
Merged

DataViews: Move template and pattern title fields #67449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f6d947a
DataViews: Move template title field
ntsekouras Dec 1, 2024
25b09d3
patternTitle field and update classNames
ntsekouras Dec 2, 2024
f019829
add classNameto BaseTitleView
ntsekouras Dec 2, 2024
46143aa
update e2e tests
ntsekouras Dec 2, 2024
88c8219
fix tests
ntsekouras Dec 3, 2024
0902cea
perf tests
ntsekouras Dec 3, 2024
ac7de7e
update tests
ntsekouras Dec 4, 2024
2bae755
update classNames + description docs for title fields
ntsekouras Dec 4, 2024
beed46c
update class names
ntsekouras Dec 4, 2024
b2a5369
update actions
ntsekouras Dec 4, 2024
1fa1eec
use TitleView
ntsekouras Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@ntsekouras
ntsekouras committed Dec 5, 2024
commit 88c82197380c1368f144ef618bcd144f4552456b
4 changes: 3 additions & 1 deletion test/e2e/specs/site-editor/template-registration.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ test.describe( 'Block template registration', () => {
.getByLabel( 'Dismiss this notice' )
.getByText( `"Author: Admin" reset.` );
await page.getByPlaceholder( 'Search' ).fill( 'Author: admin' );
await page.getByRole( 'button', { name: 'Author: Admin' } ).click();
await page
.locator( '.fields-title-field', { hasText: 'Author: Admin' } )
.click();
const actions = page.getByLabel( 'Actions' );
await actions.first().click();
await page.getByRole( 'menuitem', { name: 'Reset' } ).click();
Expand Down
6 changes: 5 additions & 1 deletion test/performance/specs/site-editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,11 @@ test.describe( 'Site Editor Performance', () => {
}

await metrics.startTracing();
await page.getByText( 'Single Posts', { exact: true } ).click();
await page
.locator( '.fields-title-field', {
hasText: 'Single Posts',
} )
.click();
await metrics.stopTracing();

// Get the durations.
Expand Down