Skip to content

Preload: parse post ID from p (path) #67465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 2 commits into from
Dec 2, 2024
Merged

Preload: parse post ID from p (path) #67465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef0308
Preload: parse post ID from p (path)
ellatrix Dec 2, 2024
fd482b9
backport
ellatrix Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backport-changelog/6.8/7695.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
https://github.com/WordPress/wordpress-develop/pull/7695

* https://github.com/WordPress/gutenberg/pull/66631
* https://github.com/WordPress/gutenberg/pull/67465
12 changes: 10 additions & 2 deletions lib/compat/wordpress-6.8/preload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,16 @@
*/
function gutenberg_block_editor_preload_paths_6_8( $paths, $context ) {
Copy link
Contributor

@youknowriad youknowriad Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally, we should build some kind of "router" that has equivalent paths to the router we use in the site editor. But this address the important use-case.

Copy link
Contributor

@youknowriad youknowriad Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would be cool to kind of allow using packages from packagist. Matching routes is a solved problem already in PHP in different packages.

if ( 'core/edit-site' === $context->name ) {
if ( ! empty( $_GET['postId'] ) ) {
$route_for_post = rest_get_route_for_post( $_GET['postId'] );
$post_id = null;
if ( isset( $_GET['postId'] ) && is_numeric( $_GET['postId'] ) ) {
$post_id = (int) $_GET['postId'];
}
if ( isset( $_GET['p'] ) && preg_match( '/^\/page\/(\d+)$/', $_GET['p'], $matches ) ) {
$post_id = (int) $matches[1];
}

if ( $post_id ) {
$route_for_post = rest_get_route_for_post( $post_id );
if ( $route_for_post ) {
$paths[] = add_query_arg( 'context', 'edit', $route_for_post );
}
Expand Down
Loading