-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Packages: Extract dom package and make it maintained with Lerna #6758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ntwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
.eslintrc.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Possible merge conflict with #6756 when it comes time to merge |
9df1f7d to
2e2e857
Compare
|
Added deprecation for all dom utils in |
|
There are packages which depend on The same applies to |
c367c49 to
2e2e857
Compare
Description
Related issues: #3955, #6594.
This PR extract new
dompackage which contains all DOM utils.Open question
Question is if we should also provide
deprecationmessage for all moved functions from@wordpress/utils?How has this been tested?
Manually:
node_modulesfolder.npm installnpm testnpm run devnpm run buildnpm run package-pluginChecklist: