Trigger some PHPUnit failures #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't search inside node_modules (inefficient) - handle spaces inside PHP filenames (perhaps unnecessary) - show rule codes in all reports (-s option)
nylen
force-pushed
the
try/test-build-failures
branch
from
fe0cc20 to
b28acb6
Compare
nylen
added a commit
that referenced
this pull request
May 5, 2017
- Do the client-side build before running PHPUnit tests; this ensures that the plugin doesn't try to enqueue non-existent JS files and cause a bunch of warnings - If a step in the build fails, go ahead and exit - Don't scan node_modules/ and vendor/ for PHP files - Run phpcs with the `-s` option (show rule identifiers in reports) - Don't require docblocks for unit tests
youknowriad
pushed a commit
that referenced
this pull request
May 10, 2017
- Do the client-side build before running PHPUnit tests; this ensures that the plugin doesn't try to enqueue non-existent JS files and cause a bunch of warnings - If a step in the build fails, go ahead and exit - Don't scan node_modules/ and vendor/ for PHP files - Run phpcs with the `-s` option (show rule identifiers in reports) - Don't require docblocks for unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.
See #586 (comment) - this PR is just testing out the possible failure conditions on Travis and making sure they fail the build as expected.