Block Editor: Fix Iframe error for links without 'href' #68024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ba33e55. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12352202760
|
talldan
approved these changes
Dec 17, 2024
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Fixes the issue for me. 🚢
Member
Author
|
Thanks for testing, Dan! |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: talldan <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: talldan <[email protected]>
Mamaduka
added
the
Backport to WP Minor Release
Contributor
|
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release. This PR is part of Gutenberg 20.0. Since the Gutenberg versions in WordPress 6.8 are from 19.4 to 20.4, this PR is already included in the 6.8 release. Therefore, there is no need to backport this PR to 6.8.2. Removing the "Backport to WP Minor Release" label. |
t-hamano
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #66751.
PR fixes an error when the Iframe component tries to intercept URLs with no
hrefattribute.Why?
The
getAttrobuteresolves tonullwhen a link has nohrefattribute.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast