Skip to content

[Yjs Collab] Reliable sync with the backend #68483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmonad wants to merge 20 commits into
base: trunk
Choose a base branch
from
Open

[Yjs Collab] Reliable sync with the backend #68483

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
aa7c01f
[Yjs Collab] WIP - Sync changes on (auto)save using Yjs
dmonad Nov 25, 2024
efcfc33
[Yjs Collab] update used dependencies
dmonad Nov 27, 2024
9aafb10
[Yjs Collab] fix collab issues introduced in upstream - ensure that e…
dmonad Dec 30, 2024
4a7fbc3
[Yjs Collab] Use heartbeat api to pull ydoc updates
dmonad Jan 1, 2025
6d88e25
[Yjs Collab] cleanup
dmonad Jan 1, 2025
cd95b82
[Yjs Collab] improve diffing
dmonad Jan 1, 2025
19580fc
[Yjs Collab] loss of selection & focus when content is saved
dmonad Jan 2, 2025
7e0c96d
[Yjs Collab] add origin to changes originating from gutenberg
dmonad Jan 2, 2025
174ae84
[Yjs Collab] documentation
dmonad Jan 3, 2025
059df5b
[Yjs Collab] improve docs
dmonad Jan 3, 2025
7f47984
[Yjs Collab] several bugfixes
dmonad Jan 6, 2025
79e833f
[Yjs Collab] add different feature flags for sync on save / heartbeat…
dmonad Jan 6, 2025
c1593a1
[Yjs Collab] Fix typo in lib/experimental/synchronization.php
dmonad Jan 8, 2025
3a3711b
[Yjs Collab] user wp_rand instead of rand
dmonad Jan 8, 2025
0665c74
[Yjs Collab] Update regexes and priorities for synchronization filters
dmonad Jan 8, 2025
a05ef90
[Yjs Collab] implement get_yinfo function in synchronization.php
dmonad Jan 8, 2025
15ce750
[Yjs Collab] fix tests
dmonad Jan 8, 2025
c7914c1
[Yjs Collab] fix php lint issues
dmonad Jan 9, 2025
158a060
[Yjs Collab] fix mobile tests
dmonad Jan 9, 2025
93db3f6
Merge branch 'trunk' into y
dmonad Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Yjs Collab] user wp_rand instead of rand 
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
  • Loading branch information
@dmonad @aaronjorbin
dmonad and aaronjorbin committed Jan 8, 2025
commit 3a3711b810ed71d3a23acde4f186f1d20d4d85e1
2 changes: 1 addition & 1 deletion lib/experimental/synchronization.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function filter_post_content_ydoc( $data, $postarr, $unsanitized_postarr ) {
}
$content = stripslashes($data['post_content']);
// generate a new clientid for updated content that can be represented as a 53bit unsigned integer (max clientid in Yjs)
$ynewclientid = rand(0, 9007199254740991); // $match[4];
$ynewclientid = wp_rand(0, 9007199254740991); // This is 2^53 – 1 which is `Number.MAX_SAFE_INTEGER` from JavaScript
$updated_yinfo = ''; // '<!-- y:gutenberg version="1" state="" new-content-clientid="' . $ynewclientid . '" -->';
// transform $content if it contains ydoc comment tag
// @todo the following regex doesn't catch the y:gutenberg comment
Expand Down