Skip to content

Remove <footer> tags since using tagName #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkaz merged 1 commit into from
May 5, 2017
Merged

Remove <footer> tags since using tagName #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove <footer> tags since using tagName
  • Loading branch information
@mkaz
mkaz committed May 5, 2017
commit c03dfd5b3f9bfa2ef3ab0e0b2445ac936f478a63
26 changes: 12 additions & 14 deletions blocks/library/pullquote/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,18 @@ registerBlock( 'core/pullquote', {
onFocus={ () => setFocus( { editable: 'value' } ) }
/>
{ ( citation || !! focus ) && (
<footer>
<Editable
tagName="footer"
value={ citation || wp.i18n.__( 'Write caption…' ) }
onChange={
( nextCitation ) => setAttributes( {
citation: nextCitation
} )
}
focus={ focus && focus.editable === 'citation' ? focus : null }
onFocus={ () => setFocus( { editable: 'citation' } ) }
inline
/>
</footer>
<Editable
tagName="footer"
value={ citation || wp.i18n.__( 'Write caption…' ) }
onChange={
( nextCitation ) => setAttributes( {
citation: nextCitation
} )
}
focus={ focus && focus.editable === 'citation' ? focus : null }
onFocus={ () => setFocus( { editable: 'citation' } ) }
inline
/>
) }
</blockquote>
);
Expand Down