Improve display of error returned from the REST API when an unsupported image type is uploaded

[adamsilverstein]

Testing

• Testing requires changes from Error when an (image) upload’s mime type is unsupported wordpress-develop#8322
• Try uploading an AVIF image directly in the block editor

[adamsilverstein]

Unfortunately, this approach leads to a flash of the image showing before the error is received and displayed:

upload.demo.mp4

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[adamsilverstein]

I have removed the Rest API change here leaving only the improved error handling.

Instead I will add the Rest error directly in core in WordPress/wordpress-develop#8322, the change here improves the error display when the mime type is not supported.

Error before

Error after

Screencast

upload.error.w.gb.mp4

[Mamaduka]

Thanks, @adamsilverstein!

[swissspidy]

@adamsilverstein Could we add a test for this? Makes it easier to understand this particular code.

[swissspidy]

Could we add a test for this? Makes it easier to understand this particular code.

ok @Mamaduka was faster 😄

[Mamaduka]

Oh, sorry. @swissspidy. I merged while your comment was posted. We could do a follow-up with a test as needed.

[Infinite-Null]

I would love to try adding a test for this @Mamaduka and @swissspidy. May I open a follow-up PR for this?

[swissspidy]

@Infinite-Null already done here: #69215

[Infinite-Null]

oo ok didn't see that 😅.