Skip to content

Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper performance #68898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Jan 28, 2025
Merged

Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper performance #68898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
435fabc
Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper perfo…
Mamaduka Jan 27, 2025
507965f
Use the loop, Luke!
Mamaduka Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions packages/block-editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,15 +1626,23 @@ const isBlockVisibleInTheInserter = (
Array.isArray( blockType.parent ) ? blockType.parent : []
).concat( Array.isArray( blockType.ancestor ) ? blockType.ancestor : [] );
if ( parents.length > 0 ) {
const rootBlockName = getBlockName( state, rootClientId );
// This is an exception to the rule that says that all blocks are visible in the inserter.
// Blocks that require a given parent or ancestor are only visible if we're within that parent.
return (
parents.includes( 'core/post-content' ) ||
parents.includes( rootBlockName ) ||
getBlockParentsByBlockName( state, rootClientId, parents ).length >
0
);
if ( parents.includes( 'core/post-content' ) ) {
return true;
}

let current = rootClientId;
let hasParent = false;
do {
if ( parents.includes( getBlockName( state, current ) ) ) {
hasParent = true;
break;
}
current = state.blocks.parents.get( current );
} while ( current );

return hasParent;
}

return true;
Expand Down
Loading