Skip to content

Classic themes: update the die handler to remove access to the Site Editor #68959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carolinan wants to merge 1 commit into from
Closed

Classic themes: update the die handler to remove access to the Site Editor #68959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions lib/compat/wordpress-6.8/site-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ function gutenberg_redirect_site_editor_deprecated_urls() {
add_action( 'admin_init', 'gutenberg_redirect_site_editor_deprecated_urls' );

/**
* Filter the `wp_die_handler` to allow access to the Site Editor's new pages page
* for Classic themes.
* Filter the `wp_die_handler` to allow access to some Site Editor pages for Classic themes.
*
* site-editor.php's access is forbidden for hybrid/classic themes and only allowed with some very special query args (some very special pages like template parts...).
* The only way to disable this protection since we're changing the urls in Gutenberg is to override the wp_die_handler.
Expand All @@ -116,9 +115,22 @@ function gutenberg_redirect_site_editor_deprecated_urls() {
* @return callable The default handler or a custom handler.
*/
function gutenberg_styles_wp_die_handler( $default_handler ) {
if ( ! wp_is_block_theme() && str_contains( $_SERVER['REQUEST_URI'], 'site-editor.php' ) && current_user_can( 'edit_theme_options' ) ) {
return '__return_false';
if ( ! wp_is_block_theme() ) {
// Trim the / that may be added when navigating through the Site Editor.
$p = isset( $_REQUEST['p'] ) ? ltrim( urldecode( $_REQUEST['p'] ), '/' ) : '';

if ( 'pattern' === $p ) {
return '__return_false';
}

if ( current_theme_supports( 'editor-styles' ) || wp_theme_has_theme_json() ) {
// Allow access to the first page of the Site Editor and the stylebook.
if ( '' === $p || 'stylebook' === $p ) {
return '__return_false';
}
}
}

return $default_handler;
}
add_filter( 'wp_die_handler', 'gutenberg_styles_wp_die_handler' );
Expand Down
Loading