-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fast follow: Redirections of deprecated site editor URLs. #68971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast follow: Redirections of deprecated site editor URLs. #68971
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6ec9aca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13063322070
|
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @peterwilsoncc!
…68971) Modifies the redirects from deprecated site-editor URLs to use 302 temporary redirects rather than 301 permanent redirects. This prevents the browser from caching the redirect as the destination will differ for logged in and logged out users. This also switches from using `wp_redirect()` to `wp_safe_redirect()` in accordance with best practices when redirecting within a WordPress site. Follow up to WordPress#67199 Incorporating changes in WordPress/wordpress-develop#7903 See https://core.trac.wordpress.org/ticket/62585 Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: Mamaduka <[email protected]>
…68971) Modifies the redirects from deprecated site-editor URLs to use 302 temporary redirects rather than 301 permanent redirects. This prevents the browser from caching the redirect as the destination will differ for logged in and logged out users. This also switches from using `wp_redirect()` to `wp_safe_redirect()` in accordance with best practices when redirecting within a WordPress site. Follow up to WordPress#67199 Incorporating changes in WordPress/wordpress-develop#7903 See https://core.trac.wordpress.org/ticket/62585 Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: Mamaduka <[email protected]>
What?
Follow up to #67199
Incorporating changes in WordPress/wordpress-develop#7903
See https://core.trac.wordpress.org/ticket/62585
See #67199
gutenberg_get_site_editor_redirection()wp_safe_redirect()Why?
Bringing suggested changes from WordPress/wordpress-develop#7903 to the plugin
How?
As above.
Testing Instructions
If you've tested the redirection of site editor URLs in the past, your browser may have the permanent redirects cached. If that is the case, you will need to test in a browser you don't usually use.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A