-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Deprecated: Introduce new module with depreaction util #6914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| package-lock=false |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # @wordpress/devtools | ||
|
|
||
| Devtools module for WordPress. | ||
|
|
||
| ## Installation | ||
|
|
||
| Install the module | ||
|
|
||
| ```bash | ||
| npm install @wordpress/devtools@next --save | ||
| ``` | ||
|
|
||
| <br/><br/><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "name": "@wordpress/devtools", | ||
|
||
| "version": "0.0.1", | ||
| "description": "Devtools module for WordPress", | ||
| "author": "WordPress", | ||
| "license": "GPL-2.0-or-later", | ||
| "keywords": [ | ||
| "wordpress", | ||
| "devtools" | ||
| ], | ||
| "homepage": "https://github.com/WordPress/gutenberg/tree/master/packages/devtools/README.md", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/WordPress/gutenberg.git" | ||
| }, | ||
| "bugs": { | ||
| "url": "https://github.com/WordPress/gutenberg/issues" | ||
| }, | ||
| "main": "src/index.js", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,6 @@ export { decodeEntities }; | |
| export { keycodes }; | ||
|
|
||
| export * from './blob-cache'; | ||
| export * from './deprecation'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love the effort to rid the world of |
||
| export * from './mediaupload'; | ||
| export * from './terms'; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,6 +137,7 @@ const entryPointNames = [ | |
|
|
||
| const gutenbergPackages = [ | ||
| 'date', | ||
| 'devtools', | ||
| 'dom', | ||
| 'element', | ||
| ]; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be neat to have something like our ESLint
deprecatedremoval rules, except for things like this which aren't necessarily "deprecated", but are related to a deprecation or should otherwise be removed by a certain version. Maybe a comment pattern similar to ESLint's inline configuration, e.g./* REMOVEME: v3.0.0 */.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would help to remove it together with the code that was deprecated. Another option would be to include
toHaveWarnedin the code which would fail when deprecation gets removed. Unless I missed something.