Block Hooks: Enable first/last child insertion next to Classic block #69241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Block hooks
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
force-pushed
the
fix/block-hooks-first-child-last-child-insertion-with-classic-content
branch
from
96ba114 to
706f354
Compare
Member
|
In a00e72d I replicated the existing tests for the post written with blocks for the case when the content was crafted with Classic Editor. The code changes look good and I was able to confirm in my testing it works as expected. |
gziolo
approved these changes
Feb 19, 2025
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
ockham
deleted the
fix/block-hooks-first-child-last-child-insertion-with-classic-content
branch
ockham
added a commit
that referenced
this pull request
Feb 20, 2025
…69241)x Allow insertion of a hooked block as the first or last child of the Post Content block (and, less importantly, of the Synced Pattern and Navigation blocks). Co-authored-by: ockham <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: t-hamano <[email protected]>
Contributor
Author
|
I've cherry-picked 8c0db8e to the |
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
…ordPress#69241)x Allow insertion of a hooked block as the first or last child of the Post Content block (and, less importantly, of the Synced Pattern and Navigation blocks). Co-authored-by: ockham <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: t-hamano <[email protected]>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ordPress#69241)x Allow insertion of a hooked block as the first or last child of the Post Content block (and, less importantly, of the Synced Pattern and Navigation blocks). Co-authored-by: ockham <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #68988.
Allow insertion of a hooked block as the first or last child of the Post Content block (and, less importantly, of the Synced Pattern and Navigation blocks).
Why?
As of #67272, Block Hooks are applied to post content. This includes injecting hooked blocks as the first or last child of the Post Content block. However, this didn't work if the post content itself didn't contain any block markup (which is possible if it was originally created in the classic editor, or if it only contains one Classic block).
This limitation is due to the way hooked block insertion works (explained here).
How?
By wrapping content that doesn't contain any blocks in a temporary Classic block wrapper, and removing the latter after Block Hooks have been applied.
Testing Instructions
Screenshots or screencast