Skip to content

Conversation

@Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Mar 6, 2025

What?

This is similar to #66654.

PR adds a post-type single template lookup to the REST API preloaded paths.

Why?

PR tries to optimize editor loading speed, especially when the default rendering mode is 'template-locked' and the editor has to wait for template resolution.

Testing Instructions

  1. Open a page.
  2. Inspect requests using the DevTools Network tab.
  3. Confirm that there's only one template lookup request (this is a different issue, and I plan to resolve it separately).

Testing Instructions for Keyboard

Same.

Screenshots or screencast

CleanShot 2025-03-06 at 11 12 17

@Mamaduka Mamaduka added the [Type] Performance Related to performance efforts label Mar 6, 2025
@Mamaduka Mamaduka self-assigned this Mar 6, 2025
@Mamaduka Mamaduka requested a review from spacedmonkey as a code owner March 6, 2025 07:46
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.8 Editor Tasks Mar 6, 2025
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested a review from fabiankaegy March 6, 2025 07:47
@Mamaduka Mamaduka added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 10, 2025
@Mamaduka Mamaduka merged commit fc030b3 into trunk Mar 10, 2025
65 checks passed
@Mamaduka Mamaduka deleted the try/post-editor-preload-template-lookup branch March 10, 2025 04:28
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.8 Editor Tasks Mar 10, 2025
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 10, 2025
@github-actions
Copy link

There was a conflict while trying to cherry-pick the commit to the wp/6.8 branch. Please resolve the conflict manually and create a PR to the wp/6.8 branch.

PRs to wp/6.8 are similar to PRs to trunk, but you should base your PR on the wp/6.8 branch instead of trunk.

# Checkout the wp/6.8 branch instead of trunk.
git checkout wp/6.8
# Create a new branch for your PR.
git checkout -b my-branch
# Cherry-pick the commit.
git cherry-pick fc030b3c883b9593ceefb42b893600bcfd723b82
# Check which files have conflicts.
git status
# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue
# Push the branch to the repository
git push origin my-branch
# Create a PR and set the base to the wp/6.8 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

@Mamaduka Mamaduka removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 10, 2025
@Mamaduka Mamaduka added the [Package] Editor /packages/editor label Mar 13, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Editor /packages/editor [Type] Performance Related to performance efforts

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants