Skip to content

Navigation Link: Don't check validity when block editing is disabled #69627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Mar 19, 2025
Merged

Navigation Link: Don't check validity when block editing is disabled #69627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25f702
Navigation Link: Don't check validity when block editing is disabled
Mamaduka Mar 19, 2025
cb701d9
Add more context
Mamaduka Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/block-library/src/navigation-link/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
store as blockEditorStore,
getColorClassName,
useInnerBlocksProps,
useBlockEditingMode,
} from '@wordpress/block-editor';
import { isURL, prependHTTP, safeDecodeURI } from '@wordpress/url';
import { useState, useEffect, useRef } from '@wordpress/element';
Expand Down Expand Up @@ -99,15 +100,25 @@ const useIsInvalidLink = ( kind, type, id ) => {
const isPostType =
kind === 'post-type' || type === 'post' || type === 'page';
const hasId = Number.isInteger( id );
const blockEditingMode = useBlockEditingMode();

const postStatus = useSelect(
( select ) => {
if ( ! isPostType ) {
return null;
}

// Fetching the posts status is an "expensive" operation. Especially for sites with large navigations.
// When the block is rendered in a template or other disabled contexts we can skip this check in order
// to avoid all these additional requests that don't really add any value in that mode.
if ( blockEditingMode === 'disabled' ) {
return null;
}

const { getEntityRecord } = select( coreStore );
return getEntityRecord( 'postType', type, id )?.status;
},
[ isPostType, type, id ]
[ isPostType, blockEditingMode, type, id ]
);

// Check Navigation Link validity if:
Expand Down
Loading