ESLint: Bump eslint-plugin-react-compiler to latest beta
#69945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -50 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
t-hamano
commented
Apr 19, 2025
| const isMountingRef = useRef( true ); | ||
| const wrapperNode = useRef(); | ||
| const textInputRef = useRef(); | ||
| const isEndingEditWithFocusRef = useRef( false ); |
Contributor
Author
There was a problem hiding this comment.
This ref was originally used as part of a conditional statement to prevent focus loss: d66d53b?diff=unified#diff-278587d24f4060dd3b05ef00adba5f9afdda8fe5b52a8587005b5012a9fc8df0R115
However, since the conditional statement itself has been removed, this ref is no longer used anywhere: https://github.com/WordPress/gutenberg/pull/32552/files#diff-278587d24f4060dd3b05ef00adba5f9afdda8fe5b52a8587005b5012a9fc8df0L158-L167
t-hamano
commented
Apr 19, 2025
Comment on lines
-299
to
-304
| // When unmounting the component if there are empty elements (the user did not complete the insertion) clean them. | ||
| const elementsReferenceRef = useRef< typeof elements >(); | ||
| useEffect( () => { | ||
| elementsReferenceRef.current = elements; | ||
| }, [ elements ] ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This ref was originally used as part of a conditional statement: https://github.com/WordPress/gutenberg/pull/36820/files#diff-3749f548d9b617ffd46aadb474aae082c8e26ce9bab26599e892f2fd9f2f1b35R160
However, since the conditional statement itself has been removed, this ref is no longer used anywhere.
t-hamano
changed the title
eslint-plugin-react-compiler to latest beta
t-hamano
force-pushed
the
update/eslint-plugin-react-compiler-20250411
branch
from
f06cfb7 to
a3976de
Compare
t-hamano
force-pushed
the
update/eslint-plugin-react-compiler-20250411
branch
from
a3976de to
a26a635
Compare
Mamaduka
reviewed
Apr 19, 2025
|
|
||
| export function useEventListeners( props ) { | ||
| const propsRef = useRef( props ); | ||
| const [ state, setState ] = useState( props ); |
Member
There was a problem hiding this comment.
What's the warning here? This latest prop pattern should still be supported.
Contributor
Author
There was a problem hiding this comment.
Some unit tests are failing, so this code is wrong, and it seems to need to be reverted.
However, the latest eslint-plugin-react-compiler displays a warning for this code 🤔
Member
|
The |
Contributor
Author
|
Do we close this PR and try |
Member
IMO, that might be easier. Let's start by just migration, and we can discuss failures one by one and how to handle them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
eslint-plugin-react-compiler#61788eslint-plugin-react-compilerto latest beta #67106What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast