Skip to content

Fix: Improve warning message and add spacing in HTMLElementControl #70002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 2 commits into from
May 1, 2025
Merged

Fix: Improve warning message and add spacing in HTMLElementControl #70002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8af30
Fix: Improve warning message and add bottom margin in HTMLElementControl
Sukhendu2002 Apr 28, 2025
d22292c
Simplify warning message
Sukhendu2002 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/block-editor/src/components/block-inspector/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
}

.components-base-control,
.components-radio-control {
.components-radio-control,
.block-editor-html-element-control {
Copy link
Member

@Mamaduka Mamaduka Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we can eliminate these special classes in the future, but for now, it makes sense to group them.

@WordPress/gutenberg-components, do we have an issue to modernize block inspector controls styling now that most components have migrated to __nextHasNoMarginBottom?

Copy link
Contributor

@t-hamano t-hamano May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a suggestion to unify the layout of the block inspector. These styles should be removed in the future.

&:where(:not(:last-child)) {
margin-bottom: $grid-unit-20;
}
Expand All @@ -20,7 +21,8 @@
// Reset unwanted margin-bottom from being applied to BaseControls within certain components.
.components-focal-point-picker-control,
.components-query-controls,
.components-range-control {
.components-range-control,
.block-editor-html-element-control {
.components-base-control {
margin-bottom: 0;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/html-element-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export default function HTMLElementControl( {
} );

return (
<VStack spacing={ 2 }>
<VStack spacing={ 2 } className="block-editor-html-element-control">
<SelectControl
__nextHasNoMarginBottom
__next40pxDefaultSize
Expand All @@ -100,7 +100,7 @@ export default function HTMLElementControl( {
{ tagName === 'main' && hasMainElementElsewhere && (
<Notice status="warning" isDismissible={ false }>
{ __(
'Multiple <main> elements detected. This is not valid HTML and may cause accessibility issues. Please change this HTML element.'
'Multiple <main> elements detected. The duplicate may be in your content or in the page template. This is not valid HTML and may cause accessibility issues. Please change this HTML element.'
) }
</Notice>
) }
Expand Down
Loading