Skip to content

Build tooling: Add linting for package.json files #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 2 commits into from
Jun 5, 2018
Merged

Build tooling: Add linting for package.json files #7001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e421bc
Build tooling: Add linting for package.json files
gziolo May 29, 2018
3adfdcd
Build tooling: Remove npm-run-all and update author field
gziolo May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 160 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 36 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@wordpress/browserslist-config": "2.1.4",
"@wordpress/custom-templated-path-webpack-plugin": "1.0.2",
"@wordpress/jest-preset-default": "1.0.6",
"@wordpress/scripts": "1.1.6",
"@wordpress/scripts": "1.2.0",
"autoprefixer": "8.2.0",
"babel-core": "6.26.0",
"babel-eslint": "8.0.3",
Expand Down Expand Up @@ -117,36 +117,59 @@
}
}
},
"npmPackageJsonLintConfig": {
"extends": "@wordpress/npm-package-json-lint-config",
"rules": {
"require-publishConfig": "error",
"valid-values-author": [
"error",
[
"The WordPress Contributors"
]
],
"valid-values-publishConfig": [
"error",
[
{
"access": "public"
}
]
]
}
},
"scripts": {
"prebuild": "check-node-version --package",
"prebuild": "npm run check-engines",
"build:packages": "rimraf ./packages/*/build ./packages/*/build-module && node ./bin/packages/build.js",
"build": "npm run build:packages && cross-env NODE_ENV=production webpack",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"lint-php": "docker-compose run --rm composer run-script lint",
"predev": "check-node-version --package",
"check-engines": "check-node-version --package",
"ci": "concurrently \"npm run lint && npm run build\" \"npm run test-unit:coverage-ci\"",
Copy link
Member

@aduth aduth May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: npm-run-all could be used here now in place of npm run lint && npm run build. I think they could occur in parallel as well? Edit: Though, the fact we're using concurrently separate here makes me think we needed them to occur in sequence. Sounds familiar, hmm..

Copy link
Member Author

@gziolo gziolo May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spend some time trying to rewrite it with npm-run-all but failed, so I removed this dependency at all in favor of concurrently :)

"predev": "npm run check-engines",
"dev": "npm run build:packages && concurrently \"cross-env webpack --watch\" \"npm run dev:packages\"",
"dev:packages": "node ./bin/packages/watch.js",
"test": "npm run lint && npm run test-unit",
"test-php": "npm run lint-php && npm run test-unit-php",
"ci": "concurrently \"npm run lint && npm run build\" \"npm run test-unit:coverage-ci\"",
"fixtures:clean": "rimraf \"core-blocks/test/fixtures/*.+(json|serialized.html)\"",
"fixtures:server-registered": "docker-compose run -w /var/www/html/wp-content/plugins/gutenberg --rm wordpress ./bin/get-server-blocks.php > core-blocks/test/server-registered.json",
"fixtures:generate": "npm run fixtures:server-registered && cross-env GENERATE_MISSING_FIXTURES=y npm run test-unit",
"fixtures:regenerate": "npm run fixtures:clean && npm run fixtures:generate",
"lint": "npm run lint-js && npm run lint-pkg-json",
"lint-js": "eslint .",
"lint-js:fix": "eslint . --fix",
"lint-php": "docker-compose run --rm composer run-script lint",
"lint-pkg-json": "wp-scripts lint-pkg-json ./packages",
"package-plugin": "./bin/build-plugin-zip.sh",
"postinstall": "lerna bootstrap --hoist && npm run build:packages",
"pot-to-php": "./bin/pot-to-php.js",
"publish:check": "lerna updated",
"publish:dev": "lerna publish --npm-tag next",
"publish:prod": "lerna publish",
"test": "npm run lint && npm run test-unit",
"test-e2e": "wp-scripts test-unit-js --config test/e2e/jest.config.json",
"test-e2e:watch": "npm run test-e2e -- --watch",
"test-php": "npm run lint-php && npm run test-unit-php",
"test-unit": "wp-scripts test-unit-js --config test/unit/jest.config.json",
"test-unit-php": "docker-compose run --rm wordpress_phpunit phpunit",
"test-unit-php-multisite": "docker-compose run -e WP_MULTISITE=1 --rm wordpress_phpunit phpunit",
"test-unit:coverage": "npm run test-unit -- --coverage",
"test-unit:coverage-ci": "npm run test-unit -- --coverage --maxWorkers 1 && codecov",
"test-unit:watch": "npm run test-unit -- --watch",
"test-e2e": "wp-scripts test-unit-js --config test/e2e/jest.config.json",
"test-e2e:watch": "npm run test-e2e -- --watch"
"test-unit-php": "docker-compose run --rm wordpress_phpunit phpunit",
"test-unit-php-multisite": "docker-compose run -e WP_MULTISITE=1 --rm wordpress_phpunit phpunit"
}
}
2 changes: 1 addition & 1 deletion packages/blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@wordpress/blob",
"version": "1.0.0-alpha.0",
"description": "Blob utils for WordPress",
"author": "WordPress",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
"keywords": [
"wordpress",
Expand Down
2 changes: 1 addition & 1 deletion packages/data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@wordpress/data",
"version": "1.0.0-alpha.0",
"description": "Data module for WordPress",
"author": "WordPress",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
"keywords": [
"wordpress",
Expand Down
Loading