Skip to content

MediaPlaceholder: Fix Regression with media URL input type to allow a local URL path #70043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 7 commits into from
May 5, 2025
Merged

MediaPlaceholder: Fix Regression with media URL input type to allow a local URL path #70043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ef940a
MediaPlaceholder: Change input type from 'url' to 'text' for URL inpu…
Mayank-Tripathi32 May 2, 2025
7eb67b0
feat: fix rtl mode
Mayank-Tripathi32 May 2, 2025
8b8363d
Revert "feat: fix rtl mode"
Mayank-Tripathi32 May 2, 2025
51e4cf2
reapply "feat: fix rtl mode""
Mayank-Tripathi32 May 2, 2025
7c19d36
feat: add comments regarding allowing relative paths in URL input by …
Mayank-Tripathi32 May 2, 2025
6064459
feat: update css to target selector over class
Mayank-Tripathi32 May 4, 2025
d18b52b
feat: move the input css into nested
Mayank-Tripathi32 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/media-placeholder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const InsertFromURLPopover = ( {
<InputControl
__next40pxDefaultSize
label={ __( 'URL' ) }
type="url"
type="text" // Use text instead of URL to allow relative paths (e.g., /image/image.jpg)
hideLabelFromVision
placeholder={ __( 'Paste or type URL' ) }
onChange={ onChange }
Expand Down
6 changes: 6 additions & 0 deletions packages/block-editor/src/components/media-placeholder/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,10 @@
@include break-small() {
width: 300px;
}

input {
// Targeting input as we're using text instead of URLs for relative paths.
/* rtl:ignore */
direction: ltr;
}
}
Loading