Skip to content

Details Block: Fix keyboard accessibility issues and allow list view selection to show up inner blocks #70056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 18 commits into from
Jun 2, 2025
Merged

Details Block: Fix keyboard accessibility issues and allow list view selection to show up inner blocks #70056

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b84e51e
fix: use key down to open/close the details block
yogeshbhutkar May 5, 2025
b324957
chore: fix import order
yogeshbhutkar May 5, 2025
7c9b0f8
fix: do not conditionally render details children
yogeshbhutkar May 5, 2025
6e93dc7
feat: expose `withIgnoreIMEEvents` to private api
yogeshbhutkar May 7, 2025
6e496b3
feat: wrap handler within `withIgnoreIMEEvents`
yogeshbhutkar May 7, 2025
a7464e9
chore(test): add e2e test for details block
yogeshbhutkar May 7, 2025
60e3607
fix: prevent space in rich-text from toggling details
yogeshbhutkar May 7, 2025
8d9a80f
chore: add CHANGELOG
yogeshbhutkar May 7, 2025
66646d5
fix: wrap key up handler with `withIgnoreIMEEvents`
yogeshbhutkar May 8, 2025
181a8ae
chore(e2e): updated tests
yogeshbhutkar May 8, 2025
51ee2b9
chore: move `CHANGELOG` to unreleased
yogeshbhutkar May 8, 2025
adac974
chore: revert usage of `withIgnoreIMEEvents`
yogeshbhutkar May 8, 2025
e51bae0
fix: apply `withIgnoreIMEEvents` to key down
yogeshbhutkar May 12, 2025
ade7309
feat: add visually hidden instructions for expanding/collapsing details
yogeshbhutkar May 16, 2025
25820e1
fix: add `aria-describedby` and add it to RichText
yogeshbhutkar May 19, 2025
4dc9cf0
fix: update aria-label for RichText
yogeshbhutkar May 21, 2025
f3d5d6b
fix: remove the usage of `aria-describedby`
yogeshbhutkar May 21, 2025
0b2c3af
chore: move `CHANGELOG` to unreleased
yogeshbhutkar Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update aria-label for RichText
  • Loading branch information
@yogeshbhutkar
yogeshbhutkar committed Jun 2, 2025
commit 4dc9cf04b2f7c8c65767527630c90c674dc58cbc
10 changes: 3 additions & 7 deletions packages/block-library/src/details/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
import {
TextControl,
ToggleControl,
VisuallyHidden,
__experimentalToolsPanel as ToolsPanel,
__experimentalToolsPanelItem as ToolsPanelItem,
privateApis as componentsPrivateApis,
Expand Down Expand Up @@ -130,14 +129,11 @@ function DetailsEdit( { attributes, setAttributes, clientId } ) {
onKeyDown={ withIgnoreIMEEvents( handleSummaryKeyDown ) }
onKeyUp={ handleSummaryKeyUp }
>
<VisuallyHidden id={ instanceId }>
{ __(
'Press Enter to expand or collapse the details.'
) }
</VisuallyHidden>
<RichText
identifier="summary"
aria-label={ __( 'Write summary' ) }
aria-label={ __(
'Write summary. Press Enter to expand or collapse the details.'
) }
aria-describedby={ instanceId }
placeholder={ placeholder || __( 'Write summary…' ) }
withoutInteractiveFormatting
Expand Down