Skip to content

Add fetchpriority=low support to script modules #70173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonruter merged 7 commits into from
Sep 8, 2025
Merged

Add fetchpriority=low support to script modules #70173

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69fe993
Add fetchpriority=low support to script modules
westonruter May 21, 2025
e2650be
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into a…
westonruter Sep 3, 2025
e2828a7
Update comment now that change landed in core
westonruter Sep 3, 2025
6c38110
Add reference to related GB issue
westonruter Sep 4, 2025
3cc250e
Use multi-line comment
westonruter Sep 4, 2025
2e10eb3
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into a…
westonruter Sep 5, 2025
1ab3c34
Add comment explaining why a11y is fetchpriority=low
westonruter Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/client-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,8 +653,14 @@ function gutenberg_default_script_modules() {
break;
}

// All script modules in Gutenberg are (currently) related to the Interactivity API which prioritizes server-side rendering.
// Therefore, the modules should be fetched with a low priority to avoid network contention with any LCP element resource.
$args = array(
'fetchpriority' => 'low',
);

$path = gutenberg_url( "build-module/{$file_name}" );
wp_register_script_module( $script_module_id, $path, $script_module_data['dependencies'], $script_module_data['version'] );
wp_register_script_module( $script_module_id, $path, $script_module_data['dependencies'], $script_module_data['version'], $args ); // The $args parameter is new as of WP 6.9 per <https://core.trac.wordpress.org/ticket/61734>.
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@sirreal sirreal Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked to make sure extra arguments to functions don't cause errors/warnings/notices and that does seem to be the case 👍

Copy link
Member Author

@westonruter westonruter Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, adding extra arguments is fine. No complaints going back even to PHP 4.3: https://3v4l.org/doYun

Any additional unnamed params could be obtained by the function via func_get_args().

}
}
remove_action( 'wp_default_scripts', 'wp_default_script_modules' );
Expand Down
Loading